Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for previously merged commits: #5643, #5642, #5641 #5650

Merged
merged 5 commits into from
May 5, 2024

Conversation

guswhitten
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #5644

What changed, and why?

Handful of unit tests for previously merged changes. Ensures this does not break again in the future.

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Apr 30, 2024
@guswhitten guswhitten marked this pull request as ready for review April 30, 2024 09:22
@compwron compwron merged commit f107091 into rubyforgood:main May 5, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for successfully submitting case contact for volunteer with only one case
2 participants