Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node version #5329

Merged
merged 4 commits into from
Nov 5, 2023
Merged

Bump node version #5329

merged 4 commits into from
Nov 5, 2023

Conversation

FireLemons
Copy link
Collaborator

@FireLemons FireLemons commented Nov 4, 2023 •
edited
Loading

What changed, and why?

  • Set minimum node version to to 16 LTS to match the minimum requirements for one of our dependencies
  • Updated the github actions javascript unit tests and linter to use this lts version
  • The javascript unit tests and linter now run for changes to the workflow file running them

See: #5254

How is this tested? (please write tests!) 💖💪

CI

@FireLemons FireLemons changed the title try bump node version Bump node version Nov 4, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code labels Nov 4, 2023
@FireLemons FireLemons merged commit 90a6afd into rubyforgood:main Nov 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@littleforest littleforest Awaiting requested review from littleforest

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FireLemons