-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix responsiveness issue for casa and volunteer data tables #5308
Conversation
…and large screens
@SajjadAhmad14 Could you give me some steps to get to a page to see this in action? The best page I can find only has two pages. |
@schoork How I approached is by tweaking into the db/seeds files to increase the size of entries for volunteers and casa cases so that I could test the resposiveness for large set of data in the tables. Please send me a message in slack if you want my help to seed the data for volunteers and casa cases. Thanks! |
@SajjadAhmad14 I'm still getting the pagination links set vertically. Are you seeing something different? |
Hi Samuel! Yes the page numbers and buttons(previous and next) on large
screen (>1200px) are showing vertically. You want to be them horizontal on
all screens? Also please confirm that buttons(previous and next) should
also be in one line so that they are also horizontal on all screens? Thanks
for the kind review!
…On Thu, Nov 2, 2023 at 2:35 PM Samuel Williams ***@***.***> wrote:
@SajjadAhmad14 <https://github.com/SajjadAhmad14> I'm still getting the
pagination links set vertically. Are you seeing something different?
[image: Screenshot 2023-11-02 at 5 33 18 AM]
<https://user-images.githubusercontent.com/50247514/279932465-25b95525-d3a1-4fd1-b21c-8978e48aef42.png>
[image: Screenshot 2023-11-02 at 5 33 12 AM]
<https://user-images.githubusercontent.com/50247514/279932467-4ddb7d91-541e-4ad1-978b-33cea678ec7e.png>
—
Reply to this email directly, view it on GitHub
<#5308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIO4AFL2YW7XHIRZKIDIXWTYCNSN5AVCNFSM6AAAAAA6M7DBLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGM3TQMJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, please make all buttons horizontal across all screen sizes. Ticket is a little confusing. |
Wow! Very quick @SajjadAhmad14 . I'm actually a fan of the previous and next buttons being on the same line as the page number buttons, but I'd like to see if we can @bcastillo32 or @MalloryPriceDesign to weigh in. |
@SajjadAhmad14 thanks for working on this! If possible, could you align the previous and next buttons on the same line as the page number buttons? |
Thanks for the review! These buttons can be on the same line but only for desktop and large screen size. These buttons got hidden on tablet and small sizes if they are on the same line with the page numbers. So for medium and small screen sizes I have to adjust them to be on a separate line for the reason of visibilty and this way the pagination style does not look same for all the screen sizes. I think the better user experience is that if we can make it look same for all the screens sizes and that's only possible with the solution that numbers and buttons align on different lines. But I am open for suggestions! Thanks! |
|
||
@media only screen and (max-width: 2560px) { | ||
|
||
#casa-cases_paginate.dataTables_paginate.paging_simple_numbers { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for using the id of the tables in these? CSS won't get propagated to all data tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schoork How do you propose to target the pagination? I am currently using CSS media queries to target different classes to make the pagination responsive. Can you guide me should I not use the CSS and use some JavaScript instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wouldn't use an id here.
#casa-cases_paginate.dataTables_paginate.paging_simple_numbers {
.dataTables_paginate.paging_simple_numbers {
@SajjadAhmad14 We need to find a solution where
Here are some screenshots of [PlainAdmin's pagination|https://demo.plainadmin.com/tables-responsive#0] (we use a lot of PlainAdmin styling in the site). The Happy to jump in/help if you get stuck. |
FYI. There is currently no way to change the number of numbered page buttons based on the size of the window (mobile does work better with fewer buttons). |
What github issue is this PR for, if any?
Resolves #5261
What changed, and why?
The pagination for volunteers and casa cases tables is now responsive.
How will this affect user permissions?
Screenshots please :)