-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CasaCase accepts date_in_care #5295
CasaCase accepts date_in_care #5295
Conversation
The date in care was not a permitted param so it was not being included in the attributes during CasaCase creation. Added it to the list of permitted params. Fixes rubyforgood#5291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test and the quick work!
Hey @bcastillo32 I just noticed your comment on my PR here, sorry for not seeing it until now! I just wanted to close the loop and make sure we're all good. I didn't want introduce a bug and then just ignore it! It looks like you captured the problem in issue #5312 and @schoork already has a fix for this in PR #5326. Is that right? I'll find something else to do assuming that's all correct. |
Hi @mattzollinhofer ! After taking a look we dont believe it was from your PR. I think it was an old design choice that was causing the youth birth month and year to be hidden from supervisors so don't worry about it :) you're good. Thank you for your contribution and we look forward to future collaboration :) |
You got me nervous on my first CASA PR 🤣! Thanks hoping to be able to help out a bit 😄. |
so sorry!! 😅 thank you again for the help! |
Yeah it turned out not to be a bug based on your pr. Thanks for checking in. |
What github issue is this PR for, if any?
Resolves #5291
What changed, and why?
The date in care was not a permitted param so it was not being included
in the attributes during CasaCase creation. Added it to the list of
permitted params.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Added an expectation to the casa_case_spec.rb
Screenshots please :)
Before
After
Feelings gif (optional)