Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CasaCase accepts date_in_care #5295

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

mattzollinhofer
Copy link
Contributor

@mattzollinhofer mattzollinhofer commented Oct 22, 2023

What github issue is this PR for, if any?

Resolves #5291

What changed, and why?

The date in care was not a permitted param so it was not being included
in the attributes during CasaCase creation. Added it to the list of
permitted params.

How will this affect user permissions?

  • Volunteer permissions: n/a
  • Supervisor permissions: n/a
  • Admin permissions: n/a

How is this tested? (please write tests!) 💖💪

Added an expectation to the casa_case_spec.rb

Screenshots please :)

Before

image
Z-2023-10-21 at 21 25 22

After

Z-2023-10-21 at 21 21 48
Z-2023-10-21 at 21 22 41
Z-2023-10-21 at 21 34 55

Feelings gif (optional)

mmmm happy

The date in care was not a permitted param so it was not being included
in the attributes during CasaCase creation. Added it to the list of
permitted params.

Fixes rubyforgood#5291
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Oct 22, 2023
Copy link
Collaborator

@schoork schoork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test and the quick work!

@schoork schoork marked this pull request as ready for review October 22, 2023 11:14
@schoork schoork merged commit 2e51729 into rubyforgood:main Oct 22, 2023
11 checks passed
@mattzollinhofer
Copy link
Contributor Author

@schoork seems to be a bad bug after this was merged and we can no longer see Youths birth month and year is gone for some reason.

Hey @bcastillo32 I just noticed your comment on my PR here, sorry for not seeing it until now!

I just wanted to close the loop and make sure we're all good. I didn't want introduce a bug and then just ignore it! It looks like you captured the problem in issue #5312 and @schoork already has a fix for this in PR #5326. Is that right? I'll find something else to do assuming that's all correct.

@mattzollinhofer mattzollinhofer deleted the mattzollinhofer/issue5291 branch November 3, 2023 23:06
@bcastillo32
Copy link
Collaborator

bcastillo32 commented Nov 4, 2023

@schoork seems to be a bad bug after this was merged and we can no longer see Youths birth month and year is gone for some reason.

Hey @bcastillo32 I just noticed your comment on my PR here, sorry for not seeing it until now!

I just wanted to close the loop and make sure we're all good. I didn't want introduce a bug and then just ignore it! It looks like you captured the problem in issue #5312 and @schoork already has a fix for this in PR #5326. Is that right? I'll find something else to do assuming that's all correct.

Hi @mattzollinhofer ! After taking a look we dont believe it was from your PR. I think it was an old design choice that was causing the youth birth month and year to be hidden from supervisors so don't worry about it :) you're good. Thank you for your contribution and we look forward to future collaboration :)

@mattzollinhofer
Copy link
Contributor Author

Hi Matt! After taking a look we dont believe it was from your PR. I think it was an old design choice that was causing the youth birth month and year to be hidden from supervisors so don't worry about it :) you're good. Thank you for your contribution and we look forward to future collaboration :)

You got me nervous on my first CASA PR 🤣! Thanks hoping to be able to help out a bit 😄.

@bcastillo32
Copy link
Collaborator

Hi Matt! After taking a look we dont believe it was from your PR. I think it was an old design choice that was causing the youth birth month and year to be hidden from supervisors so don't worry about it :) you're good. Thank you for your contribution and we look forward to future collaboration :)

You got me nervous on my first CASA PR 🤣! Thanks hoping to be able to help out a bit 😄.

so sorry!! 😅 thank you again for the help!

@schoork
Copy link
Collaborator

schoork commented Nov 4, 2023

Yeah it turned out not to be a bug based on your pr. Thanks for checking in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Youth's Date in Care" being deleted when new case is created
3 participants