Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove “+ Highlight” button from New Case Contact form #5290

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Remove “+ Highlight” button from New Case Contact form #5290

merged 1 commit into from
Oct 22, 2023

Conversation

jp524
Copy link
Collaborator

@jp524 jp524 commented Oct 19, 2023

What github issue is this PR for, if any?

Resolves #5285

What changed, and why?

The `+ Highlight' button was removed from the "New Case Contact" Form. Related JavaScript and CSS files were modified to reflect the change.

How will this affect user permissions?

  • Volunteer permissions: not affected
  • Supervisor permissions: not affected
  • Admin permissions: not affected

How is this tested? (please write tests!) 💖💪

Navigated to page and confirmed that the button was removed.
Re-ran test suite locally to ensure existing tests still pass.

Screenshots please :)

Screenshot 2023-10-19 at 12 14 43

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code erb labels Oct 19, 2023
Copy link
Collaborator

@schoork schoork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all this removed code! Good work.

@schoork schoork merged commit 48a78b6 into rubyforgood:main Oct 22, 2023
13 checks passed
@jp524 jp524 deleted the modify-case-contacts-form branch October 22, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the “+ Highlight” button from the “Enter Notes” field
2 participants