Disable 15 minutes validation for New Case Contact Form #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvaiyanidhi
requested review from
compwron,
FireLemons and
littleforest
as code owners
Fix volunteer in spec
schoork
approved these changes
Oct 22, 2023
spec/requests/case_contacts_spec.rb
Outdated
| @@ -319,7 +319,7 @@ | |||
|
|
|||
| context "with invalid parameters" do | |||
| let!(:other_casa_case) { create(:casa_case, casa_org: organization) } | |||
| let(:invalid_attributes) { {creator: volunteer, casa_case_id: [other_casa_case.id]} } | |||
| let(:invalid_attributes) { {creator: "volunteer", casa_case_id: [other_casa_case.id], occurred_at: Time.now + 1.week} } | |||
There was a problem hiding this comment.
This volunteer references a volunteer created earlier in the testing class. Any reason why you turned it into a string?
There was a problem hiding this comment.
Not sure how it got updated to string I think it was some typo error from my end. Thanks for correcting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5287
What changed, and why?
Removed the duration validation from New Case Contact form so that form can be submitted even if minutes is set to 0 instead of earlier validation of minimum 15mins
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Modified the existing tests checking for 15mins duration validation.
Screenshots please :)
Duration validation is not triggered now.
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9