created past mileage data for test data #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meamalpb
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5244
What changed, and why?
The seed data for mileage rates had their effective dates in the future, with this fix they will be in the past
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
You can try this command in the dev or testing environment rails console after running db:seed and check whether the dates are in the past
MileageRate.pluck(:effective_date)Screenshots please :)
Before change
After change
