Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Notification class to control notification components created by the notifier #5248

Merged
merged 29 commits into from
Oct 7, 2023
Merged

New Notification class to control notification components created by the notifier #5248

merged 29 commits into from
Oct 7, 2023

Conversation

FireLemons
Copy link
Collaborator

@FireLemons FireLemons commented Sep 29, 2023 •
edited
Loading

What changed, and why?

  • Created new notification class/component supporting the following actions:
    • dismiss
    • getText
    • isDismissable
    • isDismissed
    • setUserDismissable
    • setText
    • toggleUserDismissable
  • Started on validated form component and subcomponents

How is this tested? (please write tests!) 💖💪

js unit testing

Screenshots please :)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code Tests! 🎉💖👏 erb labels Sep 29, 2023
@FireLemons
created new reusbale js form validator
505dbe5
@FireLemons
Created new notification class with stubs
2bb594d
@FireLemons
wrap text in span to make it more accessible
cef384e
@FireLemons
filled in settext and gettext for notification class
b134f47
@FireLemons
update tests
056b833
@FireLemons
finished notification class
cc418d7
@FireLemons
make throwErrorIfDismissed private
0bf8871
@FireLemons
separate old tests and add section with stubs for notification tests
4dea69e
@FireLemons
fixed wrong level name
7f49ee7
@FireLemons
wrote tests for dismiss, fixed conditional to check if notification h…
1ed268a 
…as been dismissed
@FireLemons
linter
ddf3152
@FireLemons
created getText test
84c68ce
@FireLemons
get validated form component working
63be57f
@FireLemons
revert component usage
d0c35c9
@FireLemons
gave method better name
418f2a8
@FireLemons
stubbed tests, shortened wording on some tests, comments for jQuery c…
b3a4bd3 
…allback
@FireLemons
one is enough
0c8cc31
@FireLemons
created test for isUserDismissable
d504bf1
@FireLemons
combined tests
609b0eb
@FireLemons
filled in isDismissed test
3ce1c38
@FireLemons
corrected test, added test for isDismissable when notification is dis…
b7dddd0 
…missed
@FireLemons
added test for enable user dismiss button, fixed setUserDismissable b…
32f34ca 
…eing reversed
@FireLemons
added tests for Notification constructor
4e19172
@FireLemons
added tests preventing setUserDismissable from making unexpected changes
feee3a1
@FireLemons
filled in rest of setUserDismissable
99d0738
@FireLemons
filled in tests for setText
78ec022
@FireLemons FireLemons force-pushed the javascript_overhaul branch from e267e48 to b0c9f1a Compare October 7, 2023 15:20
@FireLemons FireLemons marked this pull request as ready for review October 7, 2023 16:02
@FireLemons FireLemons merged commit e8911d6 into rubyforgood:main Oct 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@littleforest littleforest Awaiting requested review from littleforest

Assignees
No one assigned
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code Tests! 🎉💖👏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FireLemons