Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript overhaul: case_contact.js #5222

Merged
merged 5 commits into from
Sep 23, 2023

Conversation

FireLemons
Copy link
Collaborator

@FireLemons FireLemons commented Sep 22, 2023

What changed, and why?

  • Removed unreachable input checks because the javascript tries to run after the page refreshes(to be added back in later)
  • Fixed miles driven warning for non physical means of contact
  • Moved all native js to jQuery so it doesn't throw errors if the elements don't exist
  • removed a test for a feature that will be refactored

How is this tested? (please write tests!) 💖💪

System tests in CI hopefully

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@FireLemons FireLemons changed the title Javascript overhaul Javascript overhaul: case_contact.js Sep 22, 2023
@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code Tests! 🎉💖👏 labels Sep 22, 2023
@FireLemons FireLemons merged commit 51f54da into rubyforgood:main Sep 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript for use by Github Labeler to mark pull requests that update Javascript code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant