Render Local Time #5190
Render Local Time #5190
Conversation
SajjadAhmad14
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
Can you add this to a random view in your local app without committing and take a screenshot? |
| browser_tz = ActiveSupport::TimeZone.find_tzinfo(cookies[:browser_time_zone]) | ||
| ActiveSupport::TimeZone.all.find { |zone| zone.tzinfo == browser_tz } || Time.zone | ||
| rescue TZInfo::UnknownTimezone, TZInfo::InvalidTimezoneIdentifier | ||
| @time_zone = Time.zone |
There was a problem hiding this comment.
we need this from the client. Can you add this as a parameter for the component?
There was a problem hiding this comment.
Hi @FireLemons, this is the local time zone of the user taken from browser. The arguments required for the component and mentioned in the issue are the time in unix timestamp format, and the format. So do I need to pass the time zone as the third argument?
There was a problem hiding this comment.
Yes, it's from the client
<%= render (LocalTimeComponent.new(format: 12, unix_timestamp: 1694349775))%> |
|
Oh my bad. I didn't know |
What github issue is this PR for, if any?
Resolves #5134
What changed, and why?
We created a new view component named LocalTimeComponent. This component renders user local time.
How is this tested? (please write tests!) 💖💪
Component is tested with both positive and negative tests.