Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_additional_expense.js improvements #5173

Merged
merged 1 commit into from
Sep 1, 2023
Merged

add_additional_expense.js improvements #5173

merged 1 commit into from
Sep 1, 2023

Conversation

FireLemons
Copy link
Collaborator

What changed, and why?

  • moved click listener from entire document to just the add additional expense button
  • replaced 3 DOM lookups and a for loop with just one DOM lookup

How is this tested? (please write tests!) 💖💪

Just a refactor. Tests exist

@github-actions github-actions bot added the javascript for use by Github Labeler to mark pull requests that update Javascript code label Aug 31, 2023
@FireLemons FireLemons merged commit 99c49cb into rubyforgood:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron Awaiting requested review from compwron

@littleforest littleforest Awaiting requested review from littleforest

Assignees
No one assigned
Labels
javascript for use by Github Labeler to mark pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FireLemons