After creating casa contact redirect back to all #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moizafzal936
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
@littleforest or @compwron what needs to be done for this one to be approved? :) |
|
The tests need to be updated. The failed test checks show errors related to the pr |
|
@moizafzal936 can you update your tests plz.:) The failed test checks show errors related to the pr |
significant logical changes
|
@bcastillo32 @littleforest @FireLemons There are significant logical changes in this latest commit, so someone other than me should do the code review. I think there was some misunderstanding of the original author of the expected result. |
Fixes for docker based tests
compwron
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5154
What changed, and why?
According to requirement, redirect back to All Casa Contact after creation.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)