[#3316] Allow for editing volunteer notes #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhian-cs
force-pushed
the
3316-allow-editing-volunteer-note
branch
from
d448115 to
cbfda05
Compare
mauricio-prl
reviewed
Apr 6, 2022
Comment on lines
+10
to
+11
| def edit | ||
| end |
There was a problem hiding this comment.
I think it's not necessary, rails will search for the view based on the controller's name
There was a problem hiding this comment.
I think rails does need the empty method, but there should be a test that fails if it is removed
compwron
reviewed
Apr 6, 2022
| volunteer = Volunteer.find(params[:volunteer_id]) | ||
| volunteer.notes.create(note_params) | ||
| redirect_to edit_volunteer_path(volunteer) | ||
| @volunteer.notes.create(note_params) |
There was a problem hiding this comment.
We are missing an authorize somewhere but that may be covered in a different ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #3316
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Before editing the note:
Note edit page:
Updated note:
