Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1990] Refactor supervisors system specs #2267

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

rhian-cs
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #1990

What changed, and why?

The system specs for the supervisors page required some refactoring for better readability.

I've also updated the volunteer factory to make it easier to create a volunteer with a supervisor (and defining such supervisor).

How will this affect user permissions?

No permissions will be affected.

How is this tested? (please write tests!) 💖💪

The system spec itself has been updated.

Screenshots please :)

No visual elements have changed.

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jul 13, 2021
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! :)

@compwron compwron merged commit 3712ed6 into rubyforgood:main Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor spec/system/supervisors/index_spec.rb
2 participants