Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2142] Make it possible to unset hearing type for a case #2184

Conversation

r-sierra
Copy link
Collaborator

What github issue is this PR for, if any?

Resolves #2142

What changed, and why?

  • Included empty value in select tag to allow unsetting the current selection.
  • Empty value is only selected when hearing type is unset on CASA case.
  • When CASA case has a hearing type, selecting the empty value will unset it.

How will this affect user permissions?

No permissions have been affected internally.

How is this tested? (please write tests!) 💖💪

I wrote system specs to check if the supervisors could set/unset the field

Screenshots please :)

With Hearing Type unset
Captura de pantalla de 2021-06-23 19-45-44

With Hearing type set
Captura de pantalla de 2021-06-23 19-45-23

@github-actions github-actions bot added erb ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jun 23, 2021
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :)

@compwron compwron merged commit 748118c into rubyforgood:main Jun 24, 2021
@r-sierra r-sierra deleted the 2142-make-it-possible-to-unset-hearing-type-for-a-case branch June 24, 2021 02:47
@r-sierra r-sierra changed the title [#2150] Make it possible to unset hearing type for a case [#2142] Make it possible to unset hearing type for a case Jun 28, 2021
@r-sierra r-sierra self-assigned this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to unset hearing type for a case
2 participants