Custom court report templates per org #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
exciting! :) |
FireLemons
force-pushed
the
custom_court_report_templates_per_org
branch
from
87eba01 to
4f3ba75
Compare
compwron
reviewed
Apr 15, 2021
| @@ -10,29 +10,26 @@ def initialize(args = {}) | |||
| @casa_case = CasaCase.find(args[:case_id]) | |||
| @volunteer = Volunteer.find(args[:volunteer_id]) | |||
|
|
|||
| @context = prepare_context | |||
| @context = prepare_context(args[:path_to_template].end_with?("default_report_template.docx")) | |||
There was a problem hiding this comment.
It would be nice to make this string a variable default_report_template.docx
compwron
reviewed
Apr 15, 2021
app/models/case_court_report.rb
Outdated
| def generate_to_string | ||
| puts @context |
compwron
reviewed
Apr 15, 2021
| desc "Deployment task: set_custom_court_docs_for_orgs" | ||
| task task_name: :environment do | ||
| CasaOrg.where(name: "Prince George CASA").map do |casa_org| | ||
| court_report_template.attach(io: File.new(Rails.root.join("app", "documents", "templates", "prince_george_report_template.docx")), filename: "prince_george_report_template.docx") |
compwron
reviewed
Apr 15, 2021
| @@ -67,7 +58,7 @@ | |||
|
|
|||
| it "has the following keys [:created_date, :casa_case, :case_contacts, :volunteer]" do | |||
| expected = %i[created_date casa_case case_contacts volunteer] | |||
There was a problem hiding this comment.
I would like to refactor this test to be more clear someday, doesn't have to be in this PR tho
FireLemons
force-pushed
the
custom_court_report_templates_per_org
branch
from
50a20a8 to
5ef5a76
Compare
compwron
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1826
What changed, and why?
There is a default court report template
Admins can upload a custom court report template
Generated court reports use the template
Pruned unused code
How will this affect user permissions?
admins can upload a custom court report template
How is this tested? (please write tests!) 💖💪
just manually for now
Screenshots please :)
Default generation
those dates are broken on QA too
Custom Template
