-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1731] Add Court Mandates to Edit CASA Case page #1795
Merged
compwron
merged 13 commits into
rubyforgood:main
from
rhian-cs:1731-add-court-mandates-to-edit-casa-case-page
Mar 1, 2021
Merged
[#1731] Add Court Mandates to Edit CASA Case page #1795
compwron
merged 13 commits into
rubyforgood:main
from
rhian-cs:1731-add-court-mandates-to-edit-casa-case-page
Mar 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to add/edit Court Mandates in Edit Case page
…iting Court Mandates Changed Add court mandate element from span to button
…ot by ascending id)
github-actions
bot
added
javascript
for use by Github Labeler to mark pull requests that update Javascript code
ruby
Pull requests that update Ruby code
Tests! 🎉💖👏
labels
Feb 26, 2021
compwron
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! :) Sounds very reasonable
This was referenced Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
for use by Github Labeler to mark pull requests that update Javascript code
ruby
Pull requests that update Ruby code
Tests! 🎉💖👏
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1731
What changed, and why?
In the Edit page of the CASA Cases, there is now a way to add Court Mandates to a specific case. These mandates are basically strings, that can be filled through text areas in the CASA Case form.
I did not follow 100% of the design suggestions described in the issue, but if that is undesirable, please let me know.
Compared to what was requested, I implemented the following:
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Automated tests:
I tested the following requirements:
Request tests
Frontend tests
Manual testing
Screenshots please :)
Overview, now the button is present at the bottom of Court details
Clicking on the (+) button creates a new textarea
Multiple textareas can be added, with no limit
The fields can be filled with any string and since they are text areas, the size can be adjusted.
After the Update button is clicked, the page is reloaded so the textareas shrink again.
Mobile view (Supervisor/Admin)
Desktop view (Volunteer)
The volunteers can also see court mandates and expand the text areas, but cannot edit them.
Mobile view (Volunteer)
Possible issues?
I took the liberty of allowing mandates to be edited, but not deleted (leaving this to #1733).
However, this may have an undesirable effect: After a mandate is added, it cannot be set to an empty string and it will not be deleted.
If any changes are required, once again please let me know.