Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "4. Court report topics (optional)" card/section to case contact form #5388

Closed
bcastillo32 opened this issue Nov 19, 2023 · 19 comments · Fixed by #5517
Closed

Add "4. Court report topics (optional)" card/section to case contact form #5388

bcastillo32 opened this issue Nov 19, 2023 · 19 comments · Fixed by #5517
Labels
🌐 Epic: Case Contact Form Improvement Improving the case contact form for a more streamlined feel Stakeholder-Feature A feature requested by the stakeholders

Comments

@bcastillo32
Copy link
Collaborator

What type(s) of user does this feature affect?

  • volunteers
  • supervisors
  • admins

Description

This is part of The Case Contact Form Improvement Epic. If you have any questions, please reach out to me, @bcastillo32, and/or @MalloryPriceDesign. The Case Contact form is one of the most important and heavily used features and your contribution will have a huge impact on CASA volunteers! :)

Reference Materials

Figma File/Prototype

Steps to view a Figma prototype:

  1. Access the provided link in your web browser.
  2. Press the play button located at the top right of the browser window.
  3. (Optional) Create a free account and log in. This grants access to view comments left on the file.
  4. (Optional) If the prototype extends beyond your screen width, click the "options" dropdown at the top right of the screen and select "fit width."
  5. Explore the prototype by clicking different areas to discover interactive elements.

Styling Chart

image

Accessing the Case Contact Form

  • Login as a Volunteer
  • Click on a case
  • Click "+ New Case Contact" button

Acceptance Criteria

  1. The card header should read "4. Court report topics (optional)" - see reference materials above
  2. Card components should match that of the figma file and styling chart - see reference materials
  3. Card text should match figma file and use correct styling - see reference materials above

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@bcastillo32 bcastillo32 added Help Wanted This is a special label that enables github to showcase issues that want help 🌐 Epic: Case Contact Form Improvement Improving the case contact form for a more streamlined feel labels Nov 19, 2023
@bcastillo32 bcastillo32 added Priority: High Stakeholder-Feature A feature requested by the stakeholders and removed Priority: High labels Nov 20, 2023
@JoshuaMaurer
Copy link

Hey Brandon! Is it ok if I pick this one up? Cheers!

@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label Dec 6, 2023
@bcastillo32
Copy link
Collaborator Author

hi @JoshuaMaurer how are you coming along? Any blockers? :)

Copy link

This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

github-actions bot commented Jan 1, 2024

This issue has been inactive for 361 hours (15.04 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

@bcastillo32 bcastillo32 added the Help Wanted This is a special label that enables github to showcase issues that want help label Jan 21, 2024
@elasticspoon
Copy link
Collaborator

elasticspoon commented Jan 23, 2024

Hey. I'm interested in taking this but I am new to this code base and I had some questions about this issue. @bcastillo32

  1. Is PR meant to both create the HTML form and modify the controller?
  2. The court report topics themselves, are they hard coded or are they stored on a model somewhere?
  3. When you specify the style ex: Content 1, is that a CSS class somewhere that I can apply or does it have some other meaning?

Thanks

@bcastillo32
Copy link
Collaborator Author

Hey. I'm interested in taking this but I am new to this code base and I had some questions about this issue. @bcastillo32

  1. Is PR meant to both create the HTML form and modify the controller?
  2. The court report topics themselves, are they hard coded or are they stored on a model somewhere?
  3. When you specify the style ex: Content 1, is that a CSS class somewhere that I can apply or does it have some other meaning?

Thanks

Hi @elasticspoon The card will need to be created. I'm not 100% clear on my understanding of controllers but perhaps I can provide a bit more context on what the end design will look like. For now the topics can be hardcoded but soon after this form revamp is done, we will want those topics to be customizable for admins. So one day an admin of an ord might decide to use different topics. Does this help answer your question?

As for the "Content 1" that is to be used for text in the card that say "optional" like the picture below
image

@bcastillo32 bcastillo32 removed the Help Wanted This is a special label that enables github to showcase issues that want help label Jan 25, 2024
@elasticspoon
Copy link
Collaborator

Well, I've got the basic look of it sketched out
image

However, I am not totally sure how best to hook this up, as in make this portion of the form actually do something. Like if admins of orgs might want to change this the information should probably live with the org rather than with the case contact.

Who would be best to consult for something like that? As in who would know more about the back end?

@bcastillo32
Copy link
Collaborator Author

Well, I've got the basic look of it sketched out image

However, I am not totally sure how best to hook this up, as in make this portion of the form actually do something. Like if admins of orgs might want to change this the information should probably live with the org rather than with the case contact.

Who would be best to consult for something like that? As in who would know more about the back end?

Hi there. if you could please join our slack channel and message me (Brandon) in the #proj-case-contact-refactor channel we can help connect with a backend dev who is a maintainer.

@bcastillo32
Copy link
Collaborator Author

@elasticspoon and apologies - I could have been more clear but the topics will be set at the org level by admins and will be applied to every case contact. Let me know is this helps. Please do connect on slack as well :)

Copy link

github-actions bot commented Feb 6, 2024

This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@elasticspoon
Copy link
Collaborator

still working

Copy link

This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@elasticspoon
Copy link
Collaborator

@bcastillo32 Hey. So a couple of questions came up:

For clarity I will call this the questions page
image
And this the answers page:
image

  1. On the questions page the user does not select anything, on the answers page the user expands every question. They go back to the questions page. Should the questions be selected now?

  2. Who has permissions to add contact topics for an organization?

@bcastillo32
Copy link
Collaborator Author

@bcastillo32 Hey. So a couple of questions came up:

For clarity I will call this the questions page image And this the answers page: image

  1. On the questions page the user does not select anything, on the answers page the user expands every question. They go back to the questions page. Should the questions be selected now?
  2. Who has permissions to add contact topics for an organization?

Hi @elasticspoon - I am going to answer these questions in our slack channel and will tag you. question one is more of a design choice and needs to be answered by Mallory. Thank you for calling this out. This is a great edge case we did not think about.

@MalloryPriceDesign
Copy link

@bcastillo32 Hey. So a couple of questions came up:
For clarity I will call this the questions page image And this the answers page: image

  1. On the questions page the user does not select anything, on the answers page the user expands every question. They go back to the questions page. Should the questions be selected now?
  2. Who has permissions to add contact topics for an organization?

Hi @elasticspoon - I am going to answer these questions in our slack channel and will tag you. question one is more of a design choice and needs to be answered by Mallory. Thank you for calling this out. This is a great edge case we did not think about.

Hi @elasticspoon! Great questions, here are some of my thoughts. Let me know if you have any other questions

  1. I do not think we need to update the selections on the questions page if the user has expanded the topics on the answers page. Are you storing these selections in the backend? If we are, then we might want to update the selections, but I'm not sure we need to store this information at all, since we should store the users' text responses in the answers page.
  2. Brandon is correct, only admins of that organization have permission to edit topics. Let me know if you have questions about the UX for that page. You can see the admin view in that same Figma file.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been inactive for 244 hours (10.17 days) and will be unassigned after 116 more hours (4.83 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

github-actions bot commented Mar 6, 2024

This issue has been inactive for 363 hours (15.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

Copy link

github-actions bot commented Mar 9, 2024

This issue has been inactive for 435 hours (18.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

Copy link

This issue has been inactive for 459 hours (19.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

@github-project-automation github-project-automation bot moved this from Todo to Merged to QA in CASA Volunteer Portal Mar 15, 2024
elasticspoon added a commit to elasticspoon/casa that referenced this issue Apr 10, 2024
In rubyforgood#5388 I added ContacTopics and ContactTopicAnswers to CaseContacts.
This allowed CasaOrgs to set topics and Users to create
ContactTopicAnswers on specific CaseContacts.

Now we want to have those answers appear in the court reports.

This PR modifies CourtReportContext to include topic information, as
well as modifies CourtReport templates to accept that information.
elasticspoon added a commit to elasticspoon/casa that referenced this issue Apr 20, 2024
In rubyforgood#5388 I added ContacTopics and ContactTopicAnswers to CaseContacts.
This allowed CasaOrgs to set topics and Users to create
ContactTopicAnswers on specific CaseContacts.

Now we want to have those answers appear in the court reports.

This PR modifies CourtReportContext to include topic information, as
well as modifies CourtReport templates to accept that information.

Modified the templates to render the correct information. If an org has
no topics the fallback is the old values.

Additionally if a org has no topics the form/details page should not
show the card for court topics.

Adds after_party update task to update prod organizations with new
templates.
elasticspoon added a commit to elasticspoon/casa that referenced this issue Apr 20, 2024
In rubyforgood#5388 I added ContacTopics and ContactTopicAnswers to CaseContacts.
This allowed CasaOrgs to set topics and Users to create
ContactTopicAnswers on specific CaseContacts.

Now we want to have those answers appear in the court reports.

This PR modifies CourtReportContext to include topic information, as
well as modifies CourtReport templates to accept that information.

Modified the templates to render the correct information. If an org has
no topics the fallback is the old values.

Additionally if a org has no topics the form/details page should not
show the card for court topics.

Adds after_party update task to update prod organizations with new
templates.
elasticspoon added a commit to elasticspoon/casa that referenced this issue Apr 20, 2024
In rubyforgood#5388 I added ContacTopics and ContactTopicAnswers to CaseContacts.
This allowed CasaOrgs to set topics and Users to create
ContactTopicAnswers on specific CaseContacts.

Now we want to have those answers appear in the court reports.

This PR modifies CourtReportContext to include topic information, as
well as modifies CourtReport templates to accept that information.

Modified the templates to render the correct information. If an org has
no topics the fallback is the old values.

Additionally if a org has no topics the form/details page should not
show the card for court topics.

Adds after_party update task to update prod organizations with new
templates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Epic: Case Contact Form Improvement Improving the case contact form for a more streamlined feel Stakeholder-Feature A feature requested by the stakeholders
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants