Merge pull request #5175 from FireLemons/fix_js_deprecation

remove if false, make for loop more readable

app/javascript/src/add_to_calendar_button.js

@@ -4,19 +4,19 @@ const Add2Calendar = require('add2calendar')
 
 function createCalendarEvents () {
   const calendarButtons = document.querySelectorAll('div.cal-btn')
-  if (!calendarButtons) return
-  calendarButtons.forEach((btn) => {
+
+  for (const calendarButton of calendarButtons) {
     const calendarEvent = new Add2Calendar({
-      title: btn.dataset.title,
-      start: btn.dataset.start,
-      end: btn.dataset.end,
-      description: btn.dataset.title,
+      title: calendarButton.dataset.title,
+      start: calendarButton.dataset.start,
+      end: calendarButton.dataset.end,
+      description: calendarButton.dataset.title,
       isAllDay: true
     })
 
-    calendarEvent.createWidget(`#${btn.id}`)
-    btn.title = btn.dataset.tooltip
-  })
+    calendarEvent.createWidget(`#${calendarButton.id}`)
+    calendarButton.title = calendarButton.dataset.tooltip
+  }
 }
 
 $(() => { // JQuery's callback for the DOM loading