Add a helper for the notifications that are marked read once seen

rubyforgood · Nov 8, 2023 · 694653b · 694653b
1 parent fc2cae4
commit 694653b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/helpers/notifications_helper.rb b/app/helpers/notifications_helper.rb
@@ -1,4 +1,8 @@
 module NotificationsHelper
+  def read_when_seen_notifications
+    ["YouthBirthdayNotification", "VolunteerBirthdayNotification", "EmancipationChecklistReminderNotification"]
+  end
+
   def notifications_after_and_including_deploy(notifications)
     latest_deploy_time = Health.instance.latest_deploy_time
 

diff --git a/app/views/notifications/index.html.erb b/app/views/notifications/index.html.erb
@@ -28,7 +28,7 @@
 </div>
 
 <% @notifications.each do |notification| %>
-  <% if ["YouthBirthdayNotification", "VolunteerBirthdayNotification", "EmancipationChecklistReminderNotification"].include? notification.type %>
+  <% if read_when_seen_notifications.include? notification.type %>
     <% notification.mark_as_read! %>
   <% end %>
 <% end %>