DRY - Code Refactor #310
DRY - Code Refactor #310
Conversation
manjunath724
force-pushed
the
code-refactor
branch
from
c7d17d4 to
4754bd8
Compare
| ) | ||
| end | ||
|
|
||
| def instance_of(value) |
There was a problem hiding this comment.
instance_of is a strange name here, but I'm struggling coming up with a better name. To me, instance_of implies you are getting another instance of something (perhaps a dup), but it's actually returning the converted value of the passed in value. Perhaps
| def instance_of(value) | |
| def serialize_value(value) |
Once that is changed, I was thinking you can also rename descend_array to serialize_array to match the pattern, but now that I look at it, there's no longer a reason to have a separate method for handling an array, and it can probably be inlined directly into this method.
| @@ -9,7 +9,7 @@ class YAMLSource | |||
|
|
|||
| def initialize(path, evaluate_erb: Config.evaluate_erb_in_yaml) | |||
| @path = path.to_s | |||
| @evaluate_erb = !!evaluate_erb | |||
| @evaluate_erb = evaluate_erb | |||
There was a problem hiding this comment.
Not sure about this one...it's kind of nice having a proper boolean, since it is accessible via the attr_reader.
There was a problem hiding this comment.
I'm on the same page as you @Fryguy . Several of the changes proposed in this PR compromise correctness or readability in favor of succinctness.
I'm comfortable with the serialize_value suggestion as a separate method as well as the formatting for case/when but I'm not excited about the other changes.
|
Closing because this is stale |
case..when..else..endblocks have been aligned verticallyeval(str)to return Booleantrue/false!!(Double not) prepended totrue/false