-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubygems deprecation #246
Fix rubygems deprecation #246
Conversation
deivid-rodriguez
commented
Jan 18, 2020
``` NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01. Gem::Specification#rubyforge_project= called from /home/deivid/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/specifications/coderay-1.1.2.gemspec:21. ```
Code Climate has analyzed commit 21b7ae8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 76.3% (-1.2% change). View more on Code Climate. |
👍 Any chance you could also include the issues I mention in #235? |
@djberg96 Yeah, I'm happy to include more improvements. But I'd rather wait for some input from maintainers first, since I already have two pending PRs here. |
Hello @korny 👋 👋! We plan to fix this warning in rubygems to not reach final users but only gem authors, but in any case it would be good to fix this in the This should be straightforward to review and merge, rubyforge hasn't existed for a very long time, any chance of finding some time to have a look? |
@korny can yo plz merge / release ... these warnings are noisy :( |
Damn! Sorry guys. I will merge it now. |
any plans for a new release ? |
1.1.3 is released now. |
thx! finally no more warnings 🎉 |