Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for blank seconds #40

Merged
merged 1 commit into from
Nov 7, 2023
Merged

tests for blank seconds #40

merged 1 commit into from
Nov 7, 2023

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Jul 9, 2023

without these tests, if return yield(sec) if sec == nil or sec.zero? is commented out, no tests fail

with these tests, if that line is commented out:

  • test_allows_nil_seconds does fail
  • test_allows_zero_seconds does not fail

i couldn't think of a way to test "blank seconds bypasses all other logic" (and don't have an opinion if that's important)

@hsbt hsbt merged commit 008a632 into ruby:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants