Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test that work is done in the same thread/fiber as the caller #34

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Jul 2, 2023

see discussion in
#30 (comment)

@jjb
Copy link
Contributor Author

jjb commented Jul 2, 2023

@ioquatix anything additional to check for fibers?

@ioquatix
Copy link
Member

ioquatix commented Jul 2, 2023

The same for Fiber.current

@jjb jjb changed the title test that work is done in the same thread as the caller test that work is done in the same thread/fiber as the caller Jul 2, 2023
@jjb
Copy link
Contributor Author

jjb commented Jul 2, 2023

The same for Fiber.current

fails, interestingly only in 3.0 https://github.com/ruby/timeout/actions/runs/5434252133/jobs/9882534220?pr=34

@eregon
Copy link
Member

eregon commented Jul 2, 2023

You need require 'fiber' on 3.0

@eregon eregon merged commit 2d2959c into ruby:master Jul 3, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 3, 2023
@jjb jjb deleted the work-thread-test branch April 30, 2024 19:29
@jjb jjb restored the work-thread-test branch April 30, 2024 19:29
@jjb jjb deleted the work-thread-test branch April 30, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants