Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated images #467

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Removed deprecated images #467

merged 2 commits into from
Feb 27, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Feb 22, 2023

I got the notification from GitHub because we still have configuration of macos-10.15 at GitHub Actions. We should remove it from test.yml at least.

But I'm not sure we also removed it from setup-ruby at this time.

@hsbt hsbt force-pushed the remove-macos-10-15 branch from 5cb883e to 54ee9e5 Compare February 22, 2023 06:00
@eregon
Copy link
Member

eregon commented Feb 22, 2023

Similarly Ubuntu 18.04 is being deprecated and has brownout periods, probably we should remove both since it's no longer possible to reliably build on those platforms with GH runners.
It seems best to remove both at the same time/for the same setup-ruby release.

Could you update this PR to also remove Ubuntu 18.04?

@hsbt
Copy link
Member Author

hsbt commented Feb 22, 2023

Sure, I will also remove ubuntu-18.04.

@hsbt hsbt force-pushed the remove-macos-10-15 branch from 716248e to 4dca0b3 Compare February 22, 2023 22:21
@hsbt hsbt changed the title Removed macos-10.15 because it will be removed at 2023-03-31 Removed deprecated images Feb 23, 2023
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eregon eregon merged commit 92aece5 into master Feb 27, 2023
@eregon eregon deleted the remove-macos-10-15 branch February 27, 2023 18:56
@hsbt
Copy link
Member Author

hsbt commented Feb 28, 2023

Thanks for merging 🚀

skshetry added a commit to iterative/dvc that referenced this pull request Feb 28, 2023
macos-10.15 image has been deprecated for a while, see https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/ and actions/runner-images#5583.

setup-ruby removed the support for these images yesterday: ruby/setup-ruby#467.

which fails our package builds. Now using macos-11 to build packages.
skshetry added a commit to iterative/dvc that referenced this pull request Feb 28, 2023
macos-10.15 image has been deprecated for a while, see https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/ and actions/runner-images#5583.

setup-ruby removed the support for these images yesterday: ruby/setup-ruby#467.

which fails our package builds. Now using macos-11 to build packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants