Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From version 0.4.0 this package started to override my user.sessions.create method #35

Closed
emish89 opened this issue Dec 11, 2024 · 3 comments · Fixed by #36
Closed

From version 0.4.0 this package started to override my user.sessions.create method #35

emish89 opened this issue Dec 11, 2024 · 3 comments · Fixed by #36

Comments

@emish89
Copy link

emish89 commented Dec 11, 2024 •
edited
Loading

Hi,

This one is quite tricky and it took some time to analyze.

After a "bundle u" in my project, this dependency updated from 0.3.2 to 0.4.0.

In version 0.4.0, this package started overriding my user.sessions.create method and I don't understand why.

When I call my user.sessions.create method, I now get a strange :

full_message': wrong number of arguments (given 2, expected 0..1) (ArgumentError)

It is 100% due to the version upgrade of this package but I can't easily understand why.

Thanks a lot for the help

cc @hsbt
@emish89 emish89 changed the title From version 0.4.0 this package started to override my session.create method From version 0.4.0 this package started to override my user.sessions.create method Dec 11, 2024
@fsmanuel
Copy link

I'm having the same issue!

@alejandrobabio
Copy link

After removing lib/random/formatter.rb it starts to use the ruby version of random/formatter.rb#alphanumeric which expect 0..1 parameter instead of 2.

     ArgumentError:
       wrong number of arguments (given 2, expected 0..1)
     # /Users/ale/.asdf/installs/ruby/3.2.1/lib/ruby/3.2.0/random/formatter.rb:241:in `alphanumeric'
     # /Users/ale/.asdf/installs/ruby/3.2.1/lib/ruby/gems/3.2.0/gems/activesupport-7.2.2.1/lib/active_support/core_ext/securerandom.rb:20:in `base58'

hsbt added a commit that referenced this issue Dec 16, 2024
@hsbt
Restore SecureRandom.alphanumeric same as Random::Formatter.alphanume…
31059a8 
…ric of Ruby 3.3/3.4

Fixes #35
@hsbt hsbt mentioned this issue Dec 16, 2024
Merged
@hsbt hsbt closed this as completed in #36 Dec 16, 2024
@hsbt hsbt closed this as completed in fbb36e3 Dec 16, 2024
matzbot pushed a commit to ruby/ruby that referenced this issue Dec 16, 2024
@hsbt @matzbot
[ruby/securerandom] Restore SecureRandom.alphanumeric same as Random:…
3a4433d 
…:Formatter.alphanumeric of Ruby 3.3/3.4

Fixes ruby/securerandom#35

ruby/securerandom@fbb36e36cc
@hsbt
Copy link
Member

hsbt commented Dec 16, 2024

I fixed this at #36 and released 0.4.1 with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore SecureRandom.alphanumeric with 0.3.x behavior ruby/securerandom
4 participants
@hsbt @fsmanuel @alejandrobabio @emish89