Fixed compatibility error with setup command and RDoc plugin on RubyGems #12330
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mterada1228 @kou After merging ruby/rdoc#1171, RubyGems tests are broken.
First, setup_command calls
Gem::RDoc.generate
directlry in that methods. I expand to argument ofRubygemsHook.new
and addedRubygemsHook#generate
for that.Second,
test/rubygems/test_gem_rdoc.rb
also usesGem::RDoc
. I added select condition ofGem::RDoc
andRDoc::RubyGemshook
for that.