New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#233 serialization of attlist is incorrect #234

Open

OlofKalufs wants to merge 3 commits into ruby:master from OlofKalufs:bugfix/#233-serialization-of-attlist-is-incorrect

+3 −1

OlofKalufs commented Jan 17, 2025

Changed so that "<!ATTLIST" is added to AttDecl contents - simliar to how it already was with "<!ENTITY"
Updated a test case to test for this

Fixes #233

OlofKalufs added 3 commits

January 17, 2025 07:28


          Added assert to testcase

1715e97


          Fixed serialization of ATTLIST

560c94d


          Added rdoc as a development dependency (for Ruby 3.5+)

4de910f

Contributor

naitoh commented Jan 18, 2025

Thanks.
4de910f is a different issue than #233, could you please separate the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet