parser pull: Add support for reusing parser #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naitoh Do you want to review this? |
kou
changed the title
reset option to PullParser
Looks good to me. |
kou
reviewed
Nov 7, 2024
test/test_pullparser.rb
Outdated
| "<message>Third valid and complete message</message>" | ||
| ] | ||
|
|
||
| reader, writer = IO.pipe |
There was a problem hiding this comment.
Could you use IO.pipe do |reader, writer| ... instead?
test/test_pullparser.rb
Outdated
| messages = [] | ||
| while parser.has_next? | ||
| start_event = parser.pull | ||
| if start_event.start_element? and start_event[0] == 'message' |
There was a problem hiding this comment.
Do we need start_element? check?
Can we simplify this like the following?
_message_start = parser.pull
message_text = parser.pull
messages << message_text[0]
_message_end = parser.pull
parser.resetThere was a problem hiding this comment.
Sure, we don't need these checks in tests because we know our test example. Fixed.
DmitryPogrebnoy
force-pushed
the
master
branch
from
37c3994 to
926afc7
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: Fix GH-214
This is for parsing XML documents stream. We can use one parser to parse multiple XML documents with this feature.