Skip to content

Commit

Permalink
ci: don't use Ruby 2.5 for gem test
Browse files Browse the repository at this point in the history
Because REXML isn't a default gem yet in Ruby 2.5.
  • Loading branch information
kou committed Jun 11, 2024
1 parent 31738cc commit 0d9b98c
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ on:
- push
- pull_request
jobs:
ruby-versions:
ruby-versions-inplace:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby-jruby
min_version: 2.5

inplace:
needs: ruby-versions
needs: ruby-versions-inplace
name: "Inplace: ${{ matrix.ruby-version }} on ${{ matrix.runs-on }}"
runs-on: ${{ matrix.runs-on }}
strategy:
Expand All @@ -20,7 +20,7 @@ jobs:
- ubuntu-latest
- macos-latest
- windows-latest
ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
ruby-version: ${{ fromJson(needs.ruby-versions-inplace.outputs.versions) }}
exclude:
- {runs-on: macos-latest, ruby-version: 2.5}
# include:
Expand All @@ -47,8 +47,14 @@ jobs:
- name: Test
run: bundle exec rake test RUBYOPT="--enable-frozen-string-literal"

ruby-versions-gems:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: cruby-jruby
min_version: 2.6 # REXML is a default gem since Ruby 2.6

gem:
needs: ruby-versions
needs: ruby-versions-gems
name: "Gem: ${{ matrix.ruby-version }} on ${{ matrix.runs-on }}"
runs-on: ${{ matrix.runs-on }}
strategy:
Expand All @@ -58,9 +64,7 @@ jobs:
- ubuntu-latest
- macos-latest
- windows-latest
exclude:
- {runs-on: macos-latest, ruby-version: 2.5}
ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
ruby-version: ${{ fromJson(needs.ruby-versions-gems.outputs.versions) }}
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
Expand Down

0 comments on commit 0d9b98c

Please sign in to comment.