Enter newline if cursor position is middle of input #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Jan 5, 2025
lib/reline/line_editor.rb
Outdated
| end | ||
| end | ||
| else | ||
| finish | ||
| end | ||
| end | ||
|
|
||
| private def ed_force_newline(_key) |
There was a problem hiding this comment.
It feels like force_newline force enter newline character instead of finish for me.
How about a name like force_finish or force_submit (the word submit is not use in reline, though)
There was a problem hiding this comment.
Sure. I have renamed ed_force_submit. Since this is a name that users can use, I thought submit would be easier to understand.
ima1zumi
force-pushed
the
enter-newline-if-cursor-position-is-middle-of-input
branch
from
4b662d8 to
9557354
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 6, 2025
(ruby/reline#802) * Enter newline if cursor position is middle of input * Add ed_force_submit to allow input confirmation on non-final lines ruby/reline@8ef534e904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the Enter key behavior so that pressing Enter in the middle of a line adds a new line even if the input can be confirmed. Pressing Enter at the end of a line will confirm the input as before.
If you prefer the previous behavior, you can set
ed_force_newlinein inputrc to allow confirmation when pressing Enter in the middle of a line. The existing Alt+Enter functionality remains unchanged.CleanShot.2025-01-05.at.17.32.26.mp4