Implement buffered output to Reline::ANSI #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimize the call of STDOUT.write
This will improve rendering performance especially when there is a busy thread `Thread.new{loop{}}`
tompng
force-pushed
the
stdout_buffering
branch
from
4bc11b1 to
c387426
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 2, 2024
(ruby/reline#790) Minimize the call of STDOUT.write This will improve rendering performance especially when there is a busy thread `Thread.new{loop{}}` ruby/reline@a6fe45f5ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering gets slow after you enter
Thread.new{loop{}}to IRB.Every
STDOUT.writecall seems to pass execution to the cpu bound thread, making rendering slow.Minimizing the number of STDOUT.write call will improve it.
Before
https://github.com/user-attachments/assets/b34dd1f2-bb79-4373-88d5-353fda2fe3bf
After
https://github.com/user-attachments/assets/a33f2e01-2591-4d45-84f5-6f43d1a067da
While trying
Thread.new{loop{}}, be careful not to press TAB key. Loading RDoc document will hang up.