Refactor perform_completon #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
simplify_complete_internal_proc
branch
2 times, most recently
from
d45c432 to
0a1e254
Compare
Flatten recursive method Remove CompletionState::COMPLETE
tompng
force-pushed
the
simplify_complete_internal_proc
branch
from
0a1e254 to
3a74d9b
Compare
ima1zumi
reviewed
Nov 10, 2024
|
|
||
| unless Encoding.compatible?(target.encoding, item.encoding) | ||
| # Crash with Encoding::CompatibilityError is required by readline-ext/test/readline/test_readline.rb | ||
| # TODO: fix the test |
There was a problem hiding this comment.
Yes. here's the failed ci log https://github.com/tompng/reline/actions/runs/11743521493/job/32716559834
| @@ -670,6 +670,19 @@ def self.vi_backward_word(line, byte_pointer) | |||
| [byte_size, width] | |||
| end | |||
|
|
|||
| def self.common_prefix(list, ignore_case: false) | |||
There was a problem hiding this comment.
Just curious, what's the purpose of this method?
There was a problem hiding this comment.
Calculates the common prefix of the list
common_prefix(["a.singleton_class", "a.singleton_method", "a.singleton_methods"]) returns
the common part prefix "a.singleton_"
Used in TAB completion
$ irb --noautocomplete
irb(main):001> a=''
=> ""
irb(main):002> a.sin[TAB]
↓
irb(main):002> a.singleton_
complete_internal_proc was doing this common prefix calculation (and also doing other things like filtering list and menu setup)
I split it to common_prefix (Pure string processing logic independent to line_editor) and filter_normalize_candidates (including completion logic).
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 11, 2024
(ruby/reline#778) Flatten recursive method Remove CompletionState::COMPLETE ruby/reline@aa5b278f3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LineEditor#perform_completionwas complicated.When autocomplete is off, state is NORMAL, show_all_if_ambiguous is set, input is
1.ab[TAB]It turned out that CompletionState::COMPLETION was not needed at all.
This pull request simplifies the flow.
Fixes tab completion with completion-ignore-case.
Unintentionally fixes bug related to the complex flow. Typing
1.ab[TAB][DELETE_CHAR_OR_LIST]wrongly triggered show_document.