Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change argument Proc to #call defined object #73

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

osyo-manga
Copy link
Contributor

Summary

Change argument Proc to #call defined object.
This is the same as the behavior of Readline.

Expected behavior

class DefineCall
  def call; end
end

# OK
Readline.completion_proc = DefineCall.new

# OK
Reline.completion_proc = DefineCall.new

Actual behavior

class DefineCall
  def call; end
end

# OK
Readline.completion_proc = DefineCall.new

# Error: ArgumentError
Reline.completion_proc = DefineCall.new

Changed methdos

  • Reline.completion_proc=
  • Reline.output_modifier_proc=
  • Reline.prompt_proc=
  • Reline.auto_indent_proc=
  • Reline.dig_perfect_match_proc=

This is the same as the behavior of Readline.
@aycabta aycabta merged commit 9a19544 into ruby:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants