Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiddle to gemspec dependencies #718

Closed
wants to merge 1 commit into from

Conversation

tompng
Copy link
Member

@tompng tompng commented Jun 6, 2024

Fiddle will be bundled gem in Ruby 3.5 ruby/ruby@10ecdeb

Fixes this test failure (irb head ubuntu latest)

Failure: test_backtrace_filtering_with_backtrace_filter(TestIRB::BacktraceFilteringTest):
  </from .*\/irbtest-.*.rb:6:in (`|'Object#)bar'/> was expected to be =~
  <"/home/runner/.rubies/ruby-head/lib/ruby/gems/3.4.0+0/gems/reline-0.5.8/lib/reline/terminfo.rb:2: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add fiddle to your Gemfile or gemspec.">.

Fiddle will be bundled gem in Ruby 3.5
@st0012
Copy link
Member

st0012 commented Jun 6, 2024

Let's handle this by updating the tests first.
Now that IRB is a Rails dependency (and depends on Reline) I want to be very cautious on adding new dependencies.
From what I can see, fiddle is not directly depended on by many projects and I'm not familiar with it enough to say it's safe for all platforms that Rails supports.

@tompng
Copy link
Member Author

tompng commented Jun 8, 2024

Fiddle is currently a default gem, expected to be always installed...
But in fact, it has trouble installing, sometimes ruby is installed without fiddle (to avoid fiddle compile failure)
I think we need to add it to dependency before 3.5 release, but we have time to find a way to handle it.

@tompng tompng closed this Jun 8, 2024
@tompng tompng deleted the add_fiddle_to_dependencies branch June 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants