Reline#readline and Reline#readmultiline to private.

[osyo-manga]

Summary

• Reline#readline and Reline#readmultiline to private
• (Reline.readline and Reline.readmultiline to module_function)

Steps to reproduce

1. include Reline
2. call #readline with receiver.

class X
  include Reline
end
x = X.new
x.readline

Expected behavior

require "reline"

class X
  include Reline
end
x = X.new

# No error: call without receiver
x.instance_eval { readline }

# Error: private method `readline' called for #<X:0x00007f8a049252d0> (NoMethodError)
x.readline

Actual behavior

require "reline"

class X
  include Reline
end
x = X.new

# No error: call without receiver
x.instance_eval { readline }

# No error
x.readline

Note

• Readline#readline is private
• (Readline.readline is module_function)
• I think Reline needs to be compatible with Readline
  • readmultiline also needs to follow readline

require "readline"

class X
  include Readline
end
x = X.new

# OK
x.instance_eval { readline }

# Error: private method `readline' called for #<X:0x00007f8a049252d0> (NoMethodError)
x.readline