Fix history navigation in vi_insert mode #55
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
:vi_insert
mode did not match any of the cursor-reset cases when navigating history. This could allow the cursor to go passed the end of the line, for example when going to a previous line, moving the cursor, and then going back to the current empty line. Trying to move the cursor left or right afterwards results in an exception. I couldn't get the arrow key codes working in the tests or I would have added one like: