Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add irb test in CI. #53

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Add irb test in CI. #53

merged 4 commits into from
Sep 3, 2019

Conversation

osyo-manga
Copy link
Contributor

Run irb test with CI.

@osyo-manga osyo-manga marked this pull request as ready for review August 30, 2019 12:19
@hsbt
Copy link
Member

hsbt commented Aug 30, 2019

I wonder why you hope to run irb test in this repository. I know reline is a dependency of irb, it should be tested on irb repository with the master branch.

@osyo-manga
Copy link
Contributor Author

It is difficult and time consuming to do terminal tests.
Therefore, the purpose is to develop more stably by executing test/irb in CI.
Also, @aycabta intention is "I think you can use test/irb temporarily because this is useful. But in the future, I would like to enhance test/reline (without using test/irb) and run the test alone".

Thank you :)

@aycabta
Copy link
Member

aycabta commented Sep 3, 2019

Thank you, I understand what you want to do.

@aycabta aycabta merged commit eaa959a into ruby:master Sep 3, 2019
@osyo-manga
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants