Consider fullwidth characters for dialog rendering #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dialog is cleared, we need to restore the text that was hidden behind dialogs.
To implement restoring full width characters hidden behind dialog,
take_range
lacks of feature.It does not provide where to render the string. column information is missing.
Sometimes we need other cut variation depending on adjacent dialog position.
The image below shows a variation of
take_range('一二三四五六七八九', 5, 8, option)
So I add
Reline::Unicode.take_mbchar_range
that has optioncover_begin, cover_end, padding
and make it return the actual cut position.