Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long input line with fullwidth charactors makes rendering and cursor position wrong #491

Closed
tompng opened this issue Jan 1, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@tompng
Copy link
Member

tompng commented Jan 1, 2023

Description

When you input long line (longer than terminal width), Line disappears when fullwidth charactors is at the end of the line.
Cursor position is wrong when typing 123 and 456 in GIF animation below

long_line

Terminal Emulator

macOS Terminal.app

@hasumikin
Copy link
Collaborator

As long as I tried, this doesn't happen on Konsole (Ubuntu), Windows Terminal, and PowerShell.
I'm personally interested in the difference between Terminal.app and others.
How about iTerm2?

tompng added a commit to tompng/reline that referenced this issue Jan 13, 2023
@tompng
Copy link
Member Author

tompng commented Jan 13, 2023

It reproduced in macOS Terminal.app, iTerm2, Alacritty, Terminal inside VSCode, and also vterm in ci

Reproduce code: tompng@e486117

Failed job result: https://github.com/tompng/reline/actions/runs/3912005379/jobs/6686085302

Failure: test_long_line_fullwidth(Reline::TestRendering::TestVTerm):
  <"Multiline REPL.\n" + "\n" + "お\n" + "\n"> was expected to include
  <"xxxxxxxxxxxx">.

@ima1zumi
Copy link
Member

I see. I could reproduce this issue. ( Terminal.app & Alacritty with tmux )
When fullwidth characters wrap just, display broken. It would be easier to understand if the width of the terminal emulator is shortened.

Screen.Recording.2023-01-14.at.1.16.51.mov

@hasumikin
Copy link
Collaborator

I see. I could reproduce it on Linux, too

@tompng
Copy link
Member Author

tompng commented Mar 26, 2024

Fixed by #614

@tompng tompng closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants