Enter newline if cursor position is middle of input

ruby · Jan 5, 2025 · 2e4a7d8 · 2e4a7d8
1 parent f09e7b1
commit 2e4a7d8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/lib/reline/line_editor.rb b/lib/reline/line_editor.rb
@@ -1673,17 +1673,10 @@ def finish
           finish
         end
       else
-        if @line_index == (@buffer_of_lines.size - 1)
-          if confirm_multiline_termination
-            finish
-          else
-            key_newline(key)
-          end
-        else
-          # should check confirm_multiline_termination to finish?
-          @line_index = @buffer_of_lines.size - 1
-          @byte_pointer = current_line.bytesize
+        if @line_index == @buffer_of_lines.size - 1 && confirm_multiline_termination
           finish
+        else
+          key_newline(key)
         end
       end
     else

diff --git a/test/reline/yamatanooroti/test_rendering.rb b/test/reline/yamatanooroti/test_rendering.rb
@@ -813,15 +813,15 @@ def test_autowrap_in_the_middle_of_a_line
       close
     end
 
-    def test_terminate_in_the_middle_of_lines
+    def test_newline_in_the_middle_of_lines
       start_terminal(5, 20, %W{ruby -I#{@pwd}/lib #{@pwd}/test/reline/yamatanooroti/multiline_repl}, startup_message: 'Multiline REPL.')
       write("def hoge\n  1\n  2\n  3\n  4\nend\n")
       write("\C-p\C-p\C-p\C-e\n")
       assert_screen(<<~EOC)
+        prompt> def hoge
+        prompt>   1
+        prompt>   2
         prompt>   3
-        prompt>   4
-        prompt> end
-        => :hoge
         prompt>
       EOC
       close