Refactor collection #1149
Refactor collection #1149
Conversation
I think we don't need to bump the major version. Because edit: I forgot Steep and TypeProf. They refer |
| { | ||
| "name" => source.name, | ||
| "remote" => source.remote, | ||
| "revision" => source.resolved_revision, | ||
| "repo_dir" => source.repo_dir | ||
| } |
There was a problem hiding this comment.
Is this replaceable with Source#to_lockfile?
There was a problem hiding this comment.
Maybe? But, the Source#to_lockfile includes "type" while existing lockfiles don't.
There was a problem hiding this comment.
Hmm, I think it's not a problem because it's not a breaking change. Including type is more descriptive, and we can keep it more DRY.
There was a problem hiding this comment.
We will have type attribute. We are planning to add another type of sources soon. So having git type here is nice.
# Conflicts: # lib/rbs/collection/config/lockfile_generator.rb # lib/rbs/collection/sources/base.rb # lib/rbs/collection/sources/stdlib.rb # lib/rbs/environment_loader.rb # sig/collection/sources.rbs # test/rbs/collection/sources/stdlib_test.rb
* Use `Lockfile` instead of re-using `Config` class * `Config` is the user edited configuration file — `rbs_collection.yaml` * `Lockfile` is the generated lockfile — `rbs_collection.lock.yaml`
* Reduces `git checkout` operation as much as possible * Stop issuing `git fetch` from `#initialize`
soutaro
force-pushed
the
refactor-collection
branch
from
6e29d76 to
7cd6aac
Compare
This is a step toward #1148, it refactor the Ruby code and RBS type definition.
Sources::*method types, to declare ifversionis required or not.Collection::Config::Lockfileis introduced to makerbs_collection.lock.yamldata structure clear.Sources::Gitis refactored that reducesgit checkoutoperation as much as possibleThe
Collection::*API changes a lot. Not very sure if we need to bump the major version of the gem...