Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestTask verbose #67

Merged
merged 2 commits into from
Feb 2, 2016
Merged

Fix TestTask verbose #67

merged 2 commits into from
Feb 2, 2016

Conversation

mblumtritt
Copy link

rake test —verbose did not result in verbose mode for MiniTest.

The verbose option needs to be forwarded to the Ruby call.

Missing tests are added.

Mike Blumtritt added 2 commits September 9, 2015 14:00
The warning tests were absent at all.
The tests for verbose did not include a test for resulting
`ruby_opts_string`.

4 new asserts added
`rake test —verbose` did not result in verbose mode for MiniTest.

The verbose option needs to be forwarded to the Ruby call.
@mblumtritt
Copy link
Author

Seems that TestRakeApplicationOptions#test_missing_require is broken in Ruby:ruby-head but not with this pull request. Can somebody help out, please?

@MarkDBlackwell
Copy link
Contributor

MarkDBlackwell commented Jul 26, 2016

rake test --verbose did not result in verbose mode for MiniTest. The verbose option needs to be forwarded to the Ruby call.

Minitest sometimes emits the message: "You have skipped tests. Run with --verbose for details."

Likely, this message stimulated the above suggestion.

This comment by @shunsuke227ono explains what's really happening—as well as this one by @prathamesh-sonpatki.

Generally, this problem only arises when three independent, particular bodies of software—Rake::TestTask, Minitest, and user test code—are combined. In that case, the proper message should suggest TESTOPTS="--verbose" (rather than --verbose).

Perhaps Rake::TestTask should detect use of Minitest, then ensure the correct message is emitted (whenever tests are skipped) by subclassing Minitest's SummaryReporter to override method summary as Minitest recommends here. Then Rake::TestTask should swap its new class into this list.

Rake's own test suite uses Minitest. When tests are skipped, it displays the problem: Minitest emits the above, incorrect message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants