Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes duplicated inclusion of Rake::DSL #254

Merged
merged 1 commit into from
Feb 22, 2018

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Feb 21, 2018

Rake::DSL is already included in Rake::TestCase

@grzuy
Copy link
Contributor Author

grzuy commented Feb 21, 2018

Apparently test build failed only for ruby 2.1, because bundle install command was installing rdoc 5.x previously for all builds, but installed rdoc 6.x for the first time with this PR (despite rdoc 6.x released 1 2 months ago), which is no longer compatible with ruby 2.1

Fetching rdoc 6.0.1
Installing rdoc 6.0.1
Gem::RuntimeRequirementNotMetError: rdoc requires Ruby version >= 2.2.2. The
current ruby version is 2.1.0.
An error occurred while installing rdoc (6.0.1), and Bundler cannot continue.
Make sure that `gem install rdoc -v '6.0.1'` succeeds before bundling.

@grzuy
Copy link
Contributor Author

grzuy commented Feb 21, 2018

Reported issue here #255

@hsbt
Copy link
Member

hsbt commented Feb 22, 2018

@gazay Can you rebase from master?

Rake::DSL is already included in Rake::TestCase
@grzuy grzuy force-pushed the remove_dup_inclusion branch from 99ff0bf to b86a13b Compare February 22, 2018 12:30
@grzuy
Copy link
Contributor Author

grzuy commented Feb 22, 2018

@hsbt Rebased

@yuki24
Copy link
Member

yuki24 commented Feb 22, 2018

I'm merging this PR since this seems like a safe change. Thanks @grzuy!

@yuki24 yuki24 merged commit 266a1d4 into ruby:master Feb 22, 2018
@grzuy
Copy link
Contributor Author

grzuy commented Feb 22, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants