Offer alternatives if rake task not found #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ This reminds me of rails/rails#15497. It would be nice if it handled typos of fobar/foobr but this is much simpler and much better than what we have right now. Note, I often typo destroy as destory so I'm partial to that rails PR. Nevertheless, this is awesome! |
| def build_task_fail(task_name) | ||
| msg = "Don't know how to build task '#{task_name}'" | ||
| if task_name.size > 1 | ||
| matches = @tasks.keys.find_all{ |e| e =~ /#{task_name}/i } |
There was a problem hiding this comment.
You probably want /#{Regexp.escape task_name}/, unless no Regexp special characters can ever occur in a task name.
There was a problem hiding this comment.
I've never seen one in the wild, but it's possible I suppose.
|
I hope to implement this feature with did_you_mean gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your rake task name happens to be wrong on the command line, the output is not that helpful. Next thing you know you're grepping through rake -T output.
This pull request does some simple matching to offer alternatives if the name you specified isn't found. For example, if you have tasks "foobar" and "foobaz", but accidentally type "rake foo" on the command line, you'll see this: