Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for rubinius #145

Merged
merged 3 commits into from
Jun 28, 2016
+5 −5
Merged

Workaround for rubinius #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7e1103
added helper method for rbx
hsbt Jun 28, 2016
d36cc95
skip broken test with rbx
hsbt Jun 28, 2016
6a94c54
remove allow_failures, their are skipped in tests
hsbt Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ before_install:
before_script:
- unset JRUBY_OPTS
script: ruby -Ilib exe/rake
matrix:
allow_failures:
- rvm: jruby-head
- rvm: rbx
- rvm: rbx-2
notifications:
email:
- [email protected]
Expand Down
4 changes: 4 additions & 0 deletions test/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,9 @@ def jruby9?
jruby? && (JRUBY_VERSION >= '9.0.0.0')
end

def rbx?
RUBY_ENGINE == 'rbx'
end

include RakefileDefinitions
end
1 change: 1 addition & 0 deletions test/test_private_reader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def setup
end

def test_private_reader_is_private
skip if rbx?
assert_private do @sample.reader end
assert_private do @sample.a end
end
Expand Down