Add character APIs for locations #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Nov 13, 2023
lib/prism/parse_result.rb
Outdated
Comment on lines
62
to
65
| # A lazily-computed cache of byte offset => character offset mappings. | ||
| def character_offsets | ||
| @character_offsets ||= { 0 => 0 } | ||
| end |
There was a problem hiding this comment.
I'm not sure this would pay off because it could become pretty large for a big file and consume N bytes for every byte in the source.
N seems to be about 60 for integer entries in a Hash:
ruby --disable-gems -e 'h={}; 1.times {|i| h[i]=i}'
12MB
ruby --disable-gems -e 'h={}; 10_000_000.times {|i| h[i]=i}'
588MB
irb(main):003:0> 576 * 1024**2 / 10_000_000.0
=> 60.3979776
I think it's better to leave this uncached for now, or do one cache entry per line.
kddnewton
force-pushed
the
character-apis
branch
from
633330b to
e5bf7e7
Compare
kddnewton
force-pushed
the
character-apis
branch
2 times, most recently
from
eb14cf5 to
f005fa0
Compare
eregon
approved these changes
Nov 15, 2023
lib/prism/parse_result.rb
Outdated
| end | ||
|
|
||
| # Return the character offset for the given byte offset. | ||
| def character(byte_offset) |
There was a problem hiding this comment.
Suggested change
| def character(byte_offset) | |
| def character_offset(byte_offset) |
It seems clearer, (e.g. it doesn't return a character) and given this is a public method, it seems even more important to be clear.
kddnewton
force-pushed
the
character-apis
branch
from
f005fa0 to
b6f37ae
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1788 by introducing:
Location#start_character_offsetLocation#end_character_offsetLocation#start_character_columnLocation#end_character_column