Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ractor safe macro to ossl.h #811

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

HoneyryderChuck
Copy link
Contributor

as requested here

@HoneyryderChuck
Copy link
Contributor Author

@rhenium the suggested macro makes the build fail for those two windows builds. not sure whether it's better to keep the original macro.

@rhenium
Copy link
Member

rhenium commented Oct 31, 2024

The failure with windows-latest 3.2 and 3.3 is irrelevant. It's failing with master, too (#812).

Could you update the commit message to include some more context? Also, "openssl.h" → "ossl.h".

in order to import or define the RUBY_TYPED_FROZEN_SHAREABLE macro.
@HoneyryderChuck
Copy link
Contributor Author

done

@rhenium rhenium changed the title move ractor safe macro to openssl.h move ractor safe macro to ossl.h Nov 6, 2024
@rhenium rhenium merged commit bd647c3 into ruby:master Nov 6, 2024
57 of 59 checks passed
@rhenium
Copy link
Member

rhenium commented Nov 6, 2024

Thank you!

@HoneyryderChuck HoneyryderChuck deleted the issue-521-4 branch November 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants