OpenSSL::PKey::PKey#sign etc. with wrong type option causes SEGV #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following script causes SEGV:
I confirmed that it seems that SEGV occurs if the last optional argument (normally a Hash) finally processed by
pkey_ctx_apply_options
is an Array or something like that.Since a non-nil check has done at each method function (e.g.
ossl_pkey_sign
) prior to callpkey_ctx_apply_options
, I addedCheck_Type
at the beginning of that function. It might be more efficient to check much earlier.