Remove RC4 cipher #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like Firefox 44 and Chrome 48 (both released in 2016-01) finally disabled RC4. https://bugs.chromium.org/p/chromium/issues/detail?id=375342 And more, OpenSSL 1.1.0 (to be released soon) will remove RC4 cipher suites from DEFAULT. Will merge unless there are objections. |
|
@jsyeo Could you clarify the commit message so that people who don't read this page can understand what it does, and the background? This removes RC4 cipher suites from SSLContext::DEFAULT_PARAMS, but it doesn't prohibit specifying explicitly, or using RC4 with OpenSSL::Cipher. then, I'll merge. Thank you! |
This commit removes insecure RC4 ciper suites [1] from being used by default. If needed, users can still specify the usage of it by specifying it explicitly. [1]: https://tools.ietf.org/html/rfc7465
|
@rhenium amended. 😉 |
|
Merged, thanks! |
dncrht
added a commit
to simplybusiness/devise_ldap_authenticatable
that referenced
this pull request
Oct 23, 2017
Our LDAP server runs on Win2003 and only supports RC4 cipher. We only care whether we use SSL or not. On SSL enabled, encryption is set to simple_tls and the supported ciphers are set. Ruby's 2.4 openssl gem has removed RC4 from its default params, however doesn't disallow its usage. See: ruby/openssl#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RC4 has insecure biases and both clients and servers should not be using it.